BranchFilter text was added backwards #10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropdown was not opened on focus, which made the filter unusable. Cache the function for getting the references with lazy result, to speed up the dropdown.
|
Could you please provide an animation/video of the new behaviour? |
Not much different from now and less weird. |
|
|
|
Will merge this in a batch with other PRs that should be merged and update release/4.0 too. The implementation just restores 3.5 handling (and some performance improvements), a proper solution should be investigated. |
|
👍
|
gerhardol
added a commit
that referenced
this pull request
Aug 8, 2022
Dropdown was not opened on focus, which made the filter unusable. Cache the function for getting the references with lazy result, to speed up the dropdown. (cherry picked from commit bb9b967)
This was referenced Aug 8, 2022
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Aug 28, 2022
The branchfilters from the sidepanel was not applied unless the filter dropdown contained any items, but the items were not updated by default since gitextensions#10136, only when needed (dropdown clicked or text typed). The dropdown was updated async FileAndForget, so 'external' usage was not always successful. This was a reason why the test 'Filters_should_behave_as_expected' had to be disabled in AppVeyor (the test still occasionally fails though).
This was referenced Aug 28, 2022
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Aug 28, 2022
The branchfilters from the sidepanel was not applied unless the filter dropdown contained any items, but the items were not updated by default since gitextensions#10136, only when needed (dropdown clicked or text typed). The dropdown was updated async FileAndForget, so 'external' usage was not always successful. This was a reason why the test 'Filters_should_behave_as_expected' had to be disabled in AppVeyor (the test still occasionally fails though).
gerhardol
added a commit
that referenced
this pull request
Aug 29, 2022
The branchfilters from the sidepanel was not applied unless the filter dropdown contained any items, but the items were not updated by default since #10136, only when needed (dropdown clicked or text typed). The dropdown was updated async FileAndForget, so 'external' usage was not always successful. This was a reason why the test 'Filters_should_behave_as_expected' had to be disabled in AppVeyor (the test still occasionally fails though).
gerhardol
added a commit
that referenced
this pull request
Aug 29, 2022
The branchfilters from the sidepanel was not applied unless the filter dropdown contained any items, but the items were not updated by default since #10136, only when needed (dropdown clicked or text typed). The dropdown was updated async FileAndForget, so 'external' usage was not always successful. This was a reason why the test 'Filters_should_behave_as_expected' had to be disabled in AppVeyor (the test still occasionally fails though). (cherry picked from commit caaccf5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9872
Proposed changes
Clearing the dropdown items changed the focus and moved the focus in the textbox to the first position, so next key was added first.
Dropdown was not opened on focus, which made the filter unusable unless you opened the dropdown first (se below).
Cache the function for getting the references with lazy result, to speed up the dropdown.
Still some weird behavior:
This PR is not perfect but it is similar to the 3.5 behavior and I have no WinForms knowledge and I would like to keep it at this.
Test methodology
manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.