Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable round operators to edit the round metadata anytime before the rounds ends in manager #2512

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

bhargavaparoksham
Copy link
Member

@bhargavaparoksham bhargavaparoksham commented Oct 26, 2023

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.
  • If this PR adds/updates any feature, it adds/updates its test script

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Description

As a Round Manager
I want to have more control over how I edit my round
So that I can make changes that fit my round's needs

Refers/Fixes

fixes #2374
fixes #2112

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:04pm

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 27, 2023

This PR is 18.0327868852459% new code.

@melissa-neira
Copy link
Member

@bhargavaparoksham let's change the copy to this

Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhargavaparoksham amazing work!!! Confirming that I'm able to edit rounds completely now, so long as the round has not ended.

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 30, 2023

🥷 Code experts: no user but you matched threshold 10

bhargavaparoksham has most 👩‍💻 activity in the files.
bhargavaparoksham has most 🧠 knowledge in the files.

See details

packages/round-manager/src/features/round/ViewRoundSettings.tsx

Activity based on git-commit:

bhargavaparoksham
OCT 416 additions & 303 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 17%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants