-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dense stride handling #774
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8ca33bd
avoid modifying stride on Dense convert_to
upsj 494a413
add stride handling to Dense precision conversion
upsj 7bedb7f
add out-parameter versions to Dense functions
upsj 550e400
improve Dense reference tests
upsj 7319687
add Reference tests for Dense output parameters
upsj 0173df2
add device tests for Dense output functions
upsj 7d04012
remove Identity kernel calls from core tests
upsj 4d7ff23
fix icc compilation issues
upsj 84b2f77
remove support for Intel 2017
upsj cc30d8f
review update
upsj 65228ef
improve dense convert_to
upsj f455156
add make_temporary_output_clone
upsj 040749f
fix ref dense temporary clone test without omp
upsj 8b62161
actually avoid copies in temporary_output_clone
upsj caa8595
unify permutation core implementations
upsj 4c847f4
avoid copies on empty matrices
upsj 4677856
fix single-precision Dense copy on dpcpp
upsj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove support for Intel 2017
- Loading branch information
commit 84b2f775e5c1734bec018d55f1c16d863e065bf0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only partially relevant to this commit, but when updating versions one could mention clang-format < 11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we only mention a lower version for clang-format. Maybe we can manage to fix that with a slightly modified format, though.