Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for C++ package manager(s) #686

Closed
wants to merge 1 commit into from
Closed

Add support for C++ package manager(s) #686

wants to merge 1 commit into from

Conversation

upsj
Copy link
Member

@upsj upsj commented Jan 2, 2021

This PR adds support for the Conan Package manager to Ginkgo. I also plan to add vcpkg support, but didn't completely understand their build process yet.

TODO:

  • Make tests optional
  • Add to CI setup (unnecessary, they do their own CI)
  • Add vcpkg support

@upsj upsj added reg:build This is related to the build system. 1:ST:WIP This PR is a work in progress. Not ready for review. labels Jan 2, 2021
@upsj upsj self-assigned this Jan 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #686 (40b7f72) into develop (297d732) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
- Coverage    92.88%   92.86%   -0.03%     
===========================================
  Files          333      333              
  Lines        24266    24266              
===========================================
- Hits         22540    22535       -5     
- Misses        1726     1731       +5     
Impacted Files Coverage Δ
omp/reorder/rcm_kernels.cpp 94.44% <0.00%> (-3.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297d732...40b7f72. Read the comment docs.

@upsj
Copy link
Member Author

upsj commented Mar 14, 2021

I decided to close this PR, since we already (almost) have a vcpkg port and conan stores their packages in a custom repo as well, similar to Spack

@upsj upsj closed this Mar 14, 2021
@upsj upsj deleted the conan branch April 9, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:WIP This PR is a work in progress. Not ready for review. reg:build This is related to the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant