Discard trailing entries of a line in a MM-format file #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
thoasm
approved these changes
Jun 21, 2024
Comment on lines
+522
to
+523
| content.ignore(max_streamsize, | ||
| '\n'); // discards rest of the line |
There was a problem hiding this comment.
nit: I would move the comment above the line to increase the readability.
Additionally, I added an article (the) in the comment:
Suggested change
| content.ignore(max_streamsize, | |
| '\n'); // discards rest of the line | |
| // discards the rest of the line | |
| content.ignore(max_streamsize, '\n'); |
Comment on lines
+592
to
+593
| content.ignore(max_streamsize, | ||
| '\n'); // discards rest of the line |
There was a problem hiding this comment.
same here:
Suggested change
| content.ignore(max_streamsize, | |
| '\n'); // discards rest of the line | |
| // discards the rest of the line | |
| content.ignore(max_streamsize, '\n'); |
With the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will discard any character in a line of a MM-format file after the values have been read in. This addresses #1627, using multiple columns within the MM-file will now lead to an exception. However, the exception is thrown by the
read_entryfunction and thus the exception message is not very helpful.