-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.8.0 to master #1622
Release 1.8.0 to master #1622
Conversation
This reverts commit c8ea7f4.
Co-authored-by: Yuhsiang M. Tsai <[email protected]>
- fix incorrect CMake version requirement - remove explicit RPATH additions - clean up configure log Co-authored-by: Yuhsiang M. Tsai <[email protected]> Co-authored-by: Marcel Koch <[email protected]>
The static builds involve changing the linker for HIP, which can't really be represented in pkg-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
- Coverage 91.33% 90.03% -1.31%
==========================================
Files 688 758 +70
Lines 56097 61155 +5058
==========================================
+ Hits 51238 55059 +3821
- Misses 4859 6096 +1237 ☔ View full report in Codecov by Sentry. |
this is diff between develop and this branch
|
Thanks for catching this diff Mike, now the diff with develop looks good. I have no idea where all this came from |
Error: The following files need to be formatted:
You can find a formatting patch under Artifacts here or run |
|
There seems to be some issue with format ? Is that expected ? |
The format job relies on the base branch (master) which isn't the same format as develop. The format bot is incorrect. Maybe in the future we should base all GithubCI scripts on develop, like we do for e.g. the mirroring |
I think we should try to stick with In that vein, I actually have a suggestion: We would have much less work if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @upsj, but need to ensure we review the master changes in a review because the changes are not shown in the pr. (or, seperating two pr sounds reasonable)
Another thing is how to handle the bug fix commit.
1.8.x should only contain the bug fix based on 1.8.0, so we need to create a branch from the tag to handle that at least.
This should be the same as #1621 but for the master branch, including all the updated commits.
Please check the README extensively, as it is the main point of failure (changes develop -> master) together with the main CMakeLists.txt