-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CUDA 12.4, METIS #1569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Unsure about the current failures.
Another part of code that fails with CUDA 12.4 is https://github.com/ginkgo-project/ginkgo/blob/develop/common/cuda_hip/multigrid/pgm_kernels.hpp.inc#L32-L48 |
When I applied the
|
@lahwaacz Regarding the Kokkos example, yes that is due to changes in Kokkos 4.x. We are reworking the Kokkos example anway ATM, which will also fix this issue. |
For info, this also came up in spack: spack/spack#42748 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one left question is whether the non-existed file in the variable is consider valid or not. LGTM in rest.
Sorry, I need to hold this up. From the comments, something like pgm also fails. I am compiling it with cuda 12.4 to ensure everything work |
Yes, I didn't get around to fixing that one, should be an easy one as well, though. |
Yes, it requires const_cast though.
It's the last piece for compiling ginkgo with CUDA 12.4 |
The fix should be in the next release of CUDA NVIDIA/cccl#1527 |
Nice! then probably guard this const_cast only with CUDA 12.4. |
Fixes #1564 #1568