-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple batched solver example #1553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly lgtm, just a few things
allb.begin() + (isys + 1) * nrows, bval); | ||
} | ||
|
||
index_type* const row_ptrs = exec->alloc<index_type>(nrows + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will operate on the application memory not our own (as they can give us the non-const memory with current const limitation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this function is meant to emulate the application.
64decae
to
65ee693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some memory/doc/name need to fix. Others LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c9d8a1c
to
e9b4ef2
Compare
e9b4ef2
to
a035ea7
Compare
Co-authored-by: Isha Aggarwal <[email protected]> Co-authored-by: Aditya Kashi <[email protected]> Signed-off-by: Pratik Nayak <[email protected]>
Signed-off-by: Pratik Nayak <[email protected]>
Co-authored-by: Yu-Hsiang-Tsai <[email protected]>
a035ea7
to
81f7473
Compare
This example shows how to wrap existing user data and solve the systems with a batched solver. It also enables recording some timings, which is very useful.