Some fixes for compiling with the -D_GLIBCXX_DEBUG flag.

[pratikvn]

This PR adds some recommended fixes needed to compile by adding the -D_GLIBCXX_DEBUG flag to all the source files. More details about the flag and its purpose can be found here

Some issues:

1. It seems like this significantly increases the runtime of some of the tests (due to the explicit bound checks ?).
2. When using stdlib containers in device code, workarounds are needed, for example in accessors.

Not sure if we want to have this for 1.5.0.

Fixes #1143

[thoasm]

I dislike the reinterpret_cast on std:;arrays and it must be addressed before I change my review.
We also need to discuss where we set the compiler options. I am fine with your approach, but there could be a reason why we opted for our own compiler flags.

Edit: I just checked your link, and they state that std::array should work fine for GCC >= 11. Maybe we can add an alias to __gnu_debug::array for older GCC?

Prior to GCC 11 a debug version of std::array was available as __gnu_debug::array in the header <debug/array>. Because array::iterator is just a pointer, the debug array can't check iterator operations, it can only check direct accesses to the container. Starting with GCC 11 all the debug capabilities are available in std::array, without needing a separate type, so __gnu_debug::array is just an alias for std::array. That alias is deprecated and may be removed in a future release.

--- GCC debug mode

[thoasm]

LGTM!

[pratikvn]

LGTM too. Feel free to approve and merge when you are ready.

[upsj]

We had three small bugs that need to be fixed, and I'll try to reduce the test runtime, but otherwise it's ready, yes