review update

ginkgo-project · Nov 26, 2019 · 44a6e36 · 44a6e36
1 parent a69e000
commit 44a6e36
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/cmake/create_test.cmake b/cmake/create_test.cmake
@@ -16,7 +16,8 @@ function(ginkgo_create_test test_name)
  add_test(NAME ${REL_BINARY_DIR}/${test_name} COMMAND ${TEST_TARGET_NAME})
 endfunction(ginkgo_create_test)
 
-function(ginkgo_create_test_link_hip test_name)
+function(ginkgo_create_hip_test_special_linkage test_name)
+ # use gcc to compile but use hip to link
  file(RELATIVE_PATH REL_BINARY_DIR
  ${PROJECT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR})
  string(REPLACE "/" "_" TEST_TARGET_NAME "${REL_BINARY_DIR}/${test_name}")
@@ -36,7 +37,7 @@ function(ginkgo_create_test_link_hip test_name)
  endif()
  target_link_libraries(${TEST_TARGET_NAME} PRIVATE ginkgo GTest::Main GTest::GTest ${ARGN})
  add_test(NAME ${REL_BINARY_DIR}/${test_name} COMMAND ${TEST_TARGET_NAME})
-endfunction(ginkgo_create_test_link_hip)
+endfunction(ginkgo_create_hip_test_special_linkage)
 
 function(ginkgo_create_cuda_test test_name)
  file(RELATIVE_PATH REL_BINARY_DIR

diff --git a/hip/test/solver/CMakeLists.txt b/hip/test/solver/CMakeLists.txt
@@ -1,6 +1,6 @@
-ginkgo_create_test_link_hip(bicgstab_kernels)
-ginkgo_create_test_link_hip(cg_kernels)
-ginkgo_create_test_link_hip(cgs_kernels)
-ginkgo_create_test_link_hip(fcg_kernels)
-ginkgo_create_test_link_hip(gmres_kernels)
-ginkgo_create_test_link_hip(ir_kernels)
+ginkgo_create_hip_test_special_linkage(bicgstab_kernels)
+ginkgo_create_hip_test_special_linkage(cg_kernels)
+ginkgo_create_hip_test_special_linkage(cgs_kernels)
+ginkgo_create_hip_test_special_linkage(fcg_kernels)
+ginkgo_create_hip_test_special_linkage(gmres_kernels)
+ginkgo_create_hip_test_special_linkage(ir_kernels)