Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): make context Value method adhere to Go standards #3897

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

FarmerChillax
Copy link
Contributor

This PR modifies the Value method in the Context struct of context.go. The purpose of this change is to make the Value method more in line with Go language standards.

slove issue #3888

see more: https://pkg.go.dev/context#WithValue

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (e09167d).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3897      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2701     -481     
==========================================
- Hits         3157     2679     -478     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.17% <100.00%> (?)
-tags go_json 99.17% <100.00%> (?)
-tags nomsgpack 99.17% <100.00%> (?)
go-1.18 99.11% <100.00%> (-0.01%) ⬇️
go-1.19 99.18% <100.00%> (-0.03%) ⬇️
go-1.20 99.18% <100.00%> (-0.03%) ⬇️
go-1.21 99.18% <100.00%> (-0.03%) ⬇️
go-1.22 99.18% <100.00%> (?)
macos-latest 99.18% <100.00%> (-0.03%) ⬇️
ubuntu-latest 99.18% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit 2b1da2b into gin-gonic:master Mar 21, 2024
54 of 55 checks passed
@FarmerChillax FarmerChillax deleted the fix-context-value branch March 22, 2024 01:28
@FarmerChillax FarmerChillax restored the fix-context-value branch March 22, 2024 01:28
@FarmerChillax FarmerChillax deleted the fix-context-value branch March 22, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants