Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-validator to v10.4.1 #2536

Merged
merged 1 commit into from
Oct 21, 2020
Merged

upgrade go-validator to v10.4.1 #2536

merged 1 commit into from
Oct 21, 2020

Conversation

Doarakko
Copy link
Contributor

fix #2534

required_if and required_unless are released in v10.4.0.
gin uses v10.2.0, so I can't use it.
https://pkg.go.dev/github.com/go-playground/validator/v10#hdr-Required_If

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #2536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2536   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        1952     1952           
=======================================
  Hits         1922     1922           
  Misses         17       17           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f969bfa...13ab0ad. Read the comment docs.

@thinkerou thinkerou self-requested a review October 21, 2020 01:35
@thinkerou thinkerou added this to the 1.7 milestone Oct 21, 2020
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit 7e444c6 into gin-gonic:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined validation function 'required_if' on field 'Field'
2 participants