Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support negative Content-Length in DataFromReader #1981

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

segevfiner
Copy link
Contributor

You can get an http.Response with ContentLength set to -1 (Chunked encoding), so for DataFromReader to be useful for those we need to support that.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1981 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage   98.69%   98.69%   +<.01%     
==========================================
  Files          40       40              
  Lines        2228     2229       +1     
==========================================
+ Hits         2199     2200       +1     
  Misses         16       16              
  Partials       13       13
Impacted Files Coverage Δ
render/reader.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461df93...058ba23. Read the comment docs.

You can get an http.Response with ContentLength set to -1 (Chunked encoding), so
for DataFromReader to be useful for those we need to support that.
@thinkerou thinkerou merged commit 20440b9 into gin-gonic:master Aug 5, 2019
@segevfiner segevfiner deleted the patch-1 branch August 5, 2019 10:54
foundations added a commit to foundations/gin that referenced this pull request Aug 7, 2019
Support negative Content-Length in DataFromReader (gin-gonic#1981)
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
You can get an http.Response with ContentLength set to -1 (Chunked encoding), so
for DataFromReader to be useful for those we need to support that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants