Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response size to LogFormatterParams #1752

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Add response size to LogFormatterParams #1752

merged 3 commits into from
Feb 22, 2019

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 27, 2019

Here is a change to make the response body size an available log formatter param.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1752 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
+ Coverage   98.48%   98.48%   +<.01%     
==========================================
  Files          41       41              
  Lines        2049     2050       +1     
==========================================
+ Hits         2018     2019       +1     
  Misses         19       19              
  Partials       12       12
Impacted Files Coverage Δ
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7daffc...7b0881e. Read the comment docs.

@sairoutine
Copy link
Contributor

It looks good to me.
To add the unit test will make your PR greater.

@thinkerou thinkerou added this to the 1.4 milestone Feb 19, 2019
@thinkerou thinkerou self-assigned this Feb 20, 2019
@thinkerou thinkerou merged commit 184661c into gin-gonic:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants