add internal package which includes json package #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 39 39
Lines 1912 1912
=======================================
Hits 1896 1896
Misses 13 13
Partials 3 3
Continue to review full report at Codecov.
|
appleboy
approved these changes
Aug 30, 2018
Jim-Lambert-Bose
pushed a commit
to Jim-Lambert-Bose/gin
that referenced
this pull request
Sep 11, 2018
add internal package which includes json package (gin-gonic#1504) chore: update vendor version (gin-gonic#1520) chore: update issue_implate (gin-gonic#1524) docs: add fnproject to gin's user list (gin-gonic#1505) example for RunLimited example for RunLimited
Jim-Lambert-Bose
pushed a commit
to Jim-Lambert-Bose/gin
that referenced
this pull request
Sep 11, 2018
add internal package which includes json package (gin-gonic#1504) chore: update vendor version (gin-gonic#1520) chore: update issue_implate (gin-gonic#1524) docs: add fnproject to gin's user list (gin-gonic#1505) example for RunLimited example for RunLimited add new capability to limit accepted connections Add golang 1.11.x testing (gin-gonic#1514) * Add golang 1.11.x testing * remove the latest golang testing See the issue: gin-gonic#1510 Update README.md (gin-gonic#1509) change `ShouldBindXML` to `ShouldBindJSON` add internal package which includes json package (gin-gonic#1504) chore: update vendor version (gin-gonic#1520) chore: update issue_implate (gin-gonic#1524) docs: add fnproject to gin's user list (gin-gonic#1505) added new capability to limit the accepted requests example for RunLimited example for RunLimited
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@appleboy @javierprovecho please review the pull request, otherwise need add one
internalpackage. thanks!json package should internal package which should not external use. ref: #1339
about
internalplease see https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/editso only
github.com/gin-gonic/gin/*can call oninternalpackage.