Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Encode function can optimize byte array handling #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KScaesar
Copy link

@KScaesar KScaesar commented Sep 5, 2024

In scenarios where byte array JSON messages are forwarded (e.g., from MQ), the previous approach required unmarshalling into an object before encoding for SSE.

The updated logic allows []byte to be passed directly, simplifying message forwarding and reducing unnecessary conversions.

// before
byteData := messageFromMQ()
data := make(map[string]any)
json.Unmarshal(byteData, &data)
sse.Encode(new(bytes.Buffer), sse.Event{
	Data: data,
})

// after
byteData := messageFromMQ()
sse.Encode(new(bytes.Buffer), sse.Event{
	Data: byteData,
})

…rwarding

In scenarios where byte array JSON messages are forwarded (e.g., from MQ), the previous approach required unmarshalling into an object before encoding for SSE.

The updated logic allows []byte to be passed directly, simplifying message forwarding and reducing unnecessary conversions.

	// before
	byteData := messageFromMQ()
	data := make(map[string]any)
	json.Unmarshal(byteData, &data)
	sse.Encode(new(bytes.Buffer), sse.Event{
		Data: data,
	})

	// after
	byteData := messageFromMQ()
	sse.Encode(new(bytes.Buffer), sse.Event{
		Data: byteData,
	})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant