Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetbrains/phpstorm-attributes as dev dependency #212

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

ishan-deepsource
Copy link
Contributor

Fixes DeepSource issue PHP-W1022 & PHP-W1031.

JetBrains\PhpStorm\Pure attribute class is part of phpstorm-stubs package so in order to find that class jetbrains/phpstorm-attributes dependency needs to be present in composer.json file.

@gigili
Copy link
Owner

gigili commented Oct 7, 2021

Thank you for the pr and help with my issues using the deepsoruce.

@all-contributors please add @ishan-deepsource for code

@allcontributors
Copy link
Contributor

@gigili

I've put up a pull request to add @ishan-deepsource! 🎉

@gigili gigili added this to To do in Good Food Tracker via automation Oct 7, 2021
@gigili gigili added the enhancement New feature or request label Oct 7, 2021
@gigili gigili merged commit 9ff71e4 into gigili:main Oct 7, 2021
Good Food Tracker automation moved this from To do to Done Oct 7, 2021
@ishan-deepsource
Copy link
Contributor Author

Welcome @gigili 🙌

To get rid of these issues, you can re-run analysis on full repo so it won't show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants