Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for ONE thermostat #72

Merged
merged 2 commits into from
May 4, 2024
Merged

Add compatibility for ONE thermostat #72

merged 2 commits into from
May 4, 2024

Conversation

Just-inc-ace
Copy link
Contributor

@Just-inc-ace Just-inc-ace commented Apr 27, 2024 •
edited by gicamm
Loading

Added support for ONE thermostat as device subtype 12
Modified def current_humidity to return non in case of ONE

@Just-inc-ace
Update hub.py
38b8aa3 
Added support for ONE thermostat as device subtype 12
@Just-inc-ace
Update climate.py
59caa53 
modified def current_humidity to return non in case of ONE
gicamm
gicamm requested changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@gicamm gicamm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to have 2 commits.
The commit should have a better comment.
Can you update your PR?
Thank you very much.

@gicamm gicamm merged commit 81b3434 into gicamm:master May 4, 2024
@gicamm
Copy link
Owner

gicamm commented May 4, 2024

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gicamm gicamm gicamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Just-inc-ace @gicamm