Support for dimmable lights & improved shutter control #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htness state. Also assumes that all bulbs support brightness...
…mable and not, and found the right permutation of states to ensure that the brightness state is correctly handled.
… become clear that the implementation is intrinsically poor. We should be 1) fixing the position sensing upstream and 2) monitoring that.
…r state correctly!
…to just be position, but don't trust it yet...
|
Hi Luca, Grazie a te! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few modifications to support:
I have some doubts about any breakages I may have introduced in features I don't use, but figured I'd share my changes with you in case you were interested in any of it.
Grazie!
Luca