Benchmark framework + bug fixes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhonghao-cliqz
approved these changes
Sep 25, 2018
| }, | ||
| "dependencies": { | ||
| "cross-fetch": "2.2.2", | ||
| "tldjs": "2.3.1" | ||
| "tldts": "^3.0.0" |
bench/dataset/create_dataset.js
Outdated
| await tearDown(); | ||
| } | ||
|
|
||
| collectDataset([ |
There was a problem hiding this comment.
Maybe the list deserves its own file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: most of the changes are actually static assets (filter lists + list of requests used for testing). Fear not!
This PR is the result of implementing a new benchmark framework to keep track of performance and memory consumption (which should allow to avoid regressions and measure improvements) as well as the comparison with other implementations of content blockers.
benchmodule to measure performance + memory consumption in Node.jsisAnchoredByHostnamein network filter matching(also fix bugs in incorrect optimizations)
Engine.matchwill now return the original filter matchingthe request instead of a pretty-printed version (caveat: when
optimizations kick-in, the original filter might not be available anymore.)
distfolder.tldtspackage for URL parsingin a TypeScript project, as a library.
The output currently looks something like that, and allows to compare the results with previous runs of the benchmarks. They only run in Node.js but in the future it would be a nice addition to make them run in different browsers as well.