Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/description updates #137

Merged
merged 16 commits into from
Dec 7, 2023
Merged

Task/description updates #137

merged 16 commits into from
Dec 7, 2023

Conversation

mauerk
Copy link
Collaborator

@mauerk mauerk commented Aug 31, 2023 •
edited
Loading

Fixes issue (if applicable) #

Proposed Changes

  • moved descriptions to slot descriptions, if applicable
  • harmonized description phrasing
  • added descriptions for ontology terms
  • added descriptions for enums

Checks

  • Builds locally

@mauerk mauerk marked this pull request as ready for review November 2, 2023 09:39
anandhi-iyappan
anandhi-iyappan requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@anandhi-iyappan anandhi-iyappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the wordings of descriptions - should we also add examples for most slots to keep the descriptions consistent?

sbilge
sbilge reviewed Nov 6, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 6, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 6, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 6, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge reviewed Nov 7, 2023
View reviewed changes
src/schema/submission.yaml Outdated Show resolved Hide resolved
sbilge
sbilge requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@sbilge sbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates. I left comments on the schema file.

sbilge
sbilge requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@sbilge sbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unresolved comment about the definition of 'Condition' class

@sbilge sbilge mentioned this pull request Nov 29, 2023
Closed
@mauerk mauerk requested a review from sbilge November 29, 2023 13:59
@mauerk mauerk merged commit 5dff2a0 into main Dec 7, 2023
4 checks passed
@mauerk mauerk deleted the task/description_updates branch December 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbilge sbilge sbilge approved these changes

@anandhi-iyappan anandhi-iyappan anandhi-iyappan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mauerk @sbilge @anandhi-iyappan