fix: resolve conflicting packages; address linting issues; resolve "@… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/" aliases in generated types
mdodsworth
commented
Jul 11, 2022
| @@ -14,7 +14,7 @@ module.exports = { | |||
| 'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | |||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | |||
| 'space-before-function-paren': 0, | |||
| 'no-unused-vars': ['warn', { varsIgnorePattern: '^_' }], | |||
| 'no-unused-vars': 'off', | |||
There was a problem hiding this comment.
recommendation is to disable no-unused-vars as it complains about unused vars in interface declarations
mdodsworth
commented
Jul 11, 2022
| @@ -1,5 +1,7 @@ | |||
| <template> | |||
| <slot /> | |||
| <div> | |||
There was a problem hiding this comment.
linting error complaining about having slot as the root element, so wrapped in a div
mdodsworth
commented
Jul 11, 2022
| @@ -93,11 +93,13 @@ export default class Scale { | |||
| const valueMin: number = min(stackedData, (arr) => min(arr, (x) => min(x))) || 0 | |||
|
|
|||
| const [dataMin, dataMax] = extent(Array.from(new Set(values.concat([valueMin, valueMax])))) | |||
| // eslint-disable-next-line no-eval | |||
There was a problem hiding this comment.
just ignoring these for now: my recommendation would be to allow a function to be passed through, rather than a string that you have to eval. That is, allow a function to be passed through that takes an optional min/max.
|
Hi @mdodsworth, Thank you for taking the time to help, I will have a look at the changes and approve them. Thanks, |
ghalex
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/" aliases in generated types
Addressing the type aliasing issue mentioned in #33.
On the way through, noticed and cleared up a few things: