add support for macOS #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh2o
reviewed
Mar 25, 2024
rvi_capture.py
Outdated
| @@ -19,10 +20,15 @@ def load_cdll(): | |||
| except OSError: | |||
| pass | |||
| raise OSError('libimobiledevice not found!') | |||
| elif sys.platform == 'darwin': | |||
| try: | |||
| return ctypes.CDLL(shutil.which('ideviceinfo')) | |||
There was a problem hiding this comment.
Is it possible to pass the path to the libimobileidevice dylib instead?
There was a problem hiding this comment.
I added code to try to find the dylib, compatible with Homebrew and MacPorts (the official ways to install libimobiledevice), with which(ideviceinfo) being a fallback. Nonetheless, using ideviceinfo doesn't seem to be different than using the dylib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of this program macOS works the same way as Linux, the only change needed is the filepath to the
imobiledevicelibrary.