Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR#863 for now (alternative instruct mode (Vicuna support, etc.)) #982

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

prusnak
Copy link
Sponsor Collaborator

@prusnak prusnak commented Apr 14, 2023

@prusnak prusnak changed the title Revert "main : alternative instruct mode (Vicuna support, etc.) (#863)" Revert PR#863 for now (alternative instruct mode (Vicuna support, etc.)) Apr 14, 2023
@prusnak prusnak requested a review from aroidzap April 14, 2023 19:25
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried chat.sh and chat-13B.sh - definitely not working.
Let's revert and make sure everything works correctly.

If needed, we should do it in smaller steps

@ggerganov ggerganov merged commit c85e03d into master Apr 14, 2023
@ggerganov ggerganov deleted the revert-863 branch April 14, 2023 19:58
@rabidcopy
Copy link
Contributor

rabidcopy commented Apr 15, 2023

Just referencing this over here as well. #863 (comment)
Seems to be the --rm-trailing-space-workaround or rather the lack of using it being the key problem. Plus two other things that should probably be addressed. Ctrl+D not actually toggling multi-line mode off once it's enabled and code pertaining to injecting the reverse prompt on EOS no longer working.

@aroidzap
Copy link
Collaborator

Just referencing this over here as well. #863 (comment) Seems to be the --rm-trailing-space-workaround or rather the lack of using it being the key problem. Plus two other things that should probably be addressed. Ctrl+D not actually togging multi-line mode off once it's enabled and code pertaining to injecting the reverse prompt on EOS no longer working.

Regarding this, I was facing same issue, until I cleared std::cin on Windows. Maybe something like clearerr(stdin); needs to be used otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants