Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode error codes on metal #7010

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Apr 30, 2024

Hopefully fixes #7009, though I haven't reproduced the issue myself so can't confirm.

@slaren
Copy link
Collaborator

slaren commented Apr 30, 2024

Would it be possible to use the localizedDescription property instead? I imagine that would work everywhere. https://developer.apple.com/documentation/metal/mtlcommandbuffererror/2887326-localizeddescription

@bakkot
Copy link
Contributor Author

bakkot commented Apr 30, 2024

Oh, sure, that's much nicer:

ggml_metal_graph_compute: command buffer 6 failed with status 5
error: Insufficient Memory (00000008:kIOGPUCommandBufferCallbackErrorOutOfMemory)

For some reason that's not documented on the Objective C docs (afaict), just the Swift ones, but accessing it in the obvious way does seem to work.

@slaren slaren merged commit f364eb6 into ggerganov:master Apr 30, 2024
56 of 57 checks passed
@bakkot bakkot deleted the hardcode-codes branch April 30, 2024 15:14
nopperl pushed a commit to nopperl/llama.cpp that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix build fails on apple silicon
2 participants