Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make : change GNU make default CXX from g++ to c++ #6966

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

przemoc
Copy link
Contributor

@przemoc przemoc commented Apr 28, 2024

Analogous change to the one from sister project:

Assuming g++ is the default C++ compiler is the sin of GNU make.

@ggerganov ggerganov merged commit 577277f into ggerganov:master Apr 29, 2024
56 checks passed
@przemoc przemoc deleted the change-default-cxx-in-make branch April 29, 2024 13:13
@przemoc
Copy link
Contributor Author

przemoc commented Apr 29, 2024

I see that on 577277f in windows-latest-cmake (avx512, -DLLAMA_NATIVE=OFF -DLLAMA_BUILD_SERVER=ON -DLLAMA_AVX512=ON -DBUIL... step Test (Intel SDE) failed:

23/23 Test #25: test-json-schema-to-grammar .........***Timeout 900.06 sec

96% tests passed, 1 tests failed out of 23

But I don't see how it could be related to the change this PR did.
I suspect it is some random failure, but please let me know if I'm wrong.

nopperl pushed a commit to nopperl/llama.cpp that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants