Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add nvidia and amd backends index #6157

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

AidanBeltonS
Copy link
Collaborator

@AidanBeltonS AidanBeltonS commented Mar 19, 2024

This PR adds an associated index for the CUDA and HIP backends. This prevents a runtime failure when trying to target these two vendors. As currently the Nvidia build fails to run in these cases.

Tested on A100 and PVC

@AidanBeltonS
Copy link
Collaborator Author

@NeoZhangJianyu
Copy link
Collaborator

This PR adds an associated index for the CUDA and HIP backends. This prevents a runtime failure when trying to target these two vendors. As currently the Nvidia build fails to run in these cases.

Tested on A100 and PVC

Due to the code have AMD branch, it's better to verify on AMD GPU to cover this branch.
Is it possible to test on AMD too?

@AidanBeltonS
Copy link
Collaborator Author

This PR adds an associated index for the CUDA and HIP backends. This prevents a runtime failure when trying to target these two vendors. As currently the Nvidia build fails to run in these cases.
Tested on A100 and PVC

Due to the code have AMD branch, it's better to verify on AMD GPU to cover this branch. Is it possible to test on AMD too?

I have verified it on AMD GPU as well, specifically the MI210.

Copy link
Collaborator

@abhilash1910 abhilash1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@abhilash1910
Copy link
Collaborator

builds not related to sycl are failing, can be merged.
cc @ggerganov

@abhilash1910 abhilash1910 merged commit c5b8595 into ggerganov:master Mar 21, 2024
31 of 54 checks passed
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants