-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nv/AMD sycl target build cmd #5357
Conversation
For SYCL runtime perf across nv and amd vendors this is based on sycl.cpp codebase. Features which will get added to the sycl code base will be tested as is on the other vendors . Priority wise we support Intel GPUs optimization and see performance of codebase on nv and amd on sycl runtime and provide improvements. |
|
@abhilash1910 @AidanBeltonS has been trying to run the SYCL version on Nvidia GPUs, but the tests are still not passing. |
I tried running it on Nvidia and AMD on Linux, but ran into some issues. It takes very long to compile and still only reports the Intel/CPU devices in the system, then dies.
|
When you build for non spirv targets (i.e. NVidia and AMD) you must pass the device triple to the compiler i.e. However, as pointed out before NVidia and AMD are not yet passing all tests so you should not expect it to run properly just yet. |
@abhilash1910 @AidanBeltonS I suggest adding a sub chapter "AOT" in chapter "build" in README-sycl.md. |
Yes, I think we should update the CMake and README to properly support this. However, I do not propose making this change until we have the CUDA and HIP backends passing tests which is currently not the case. |
Addressed in #5738.Closing |
Cmake modification for Nv/AMD SYCL builds.
@NeoZhangJianyu @ggerganov @airMeng @AidanBeltonS @Alcpz