Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: Restore default package's buildInputs #3261 #3262

Merged

Conversation

tpdns90321
Copy link
Contributor

@tpdns90321 tpdns90321 commented Sep 19, 2023

When added support for ROCM to flake(#2808), modified buildInputs, so the dependencies defined in osSpecific that are required for darwin support were not available.
Simply changed the value of buildInputs to osSpecific.

@tpdns90321 tpdns90321 changed the title flake:Restore default package's buildInputs(#3261) flake:Restore default package's buildInputs #3261 Sep 19, 2023
@tpdns90321 tpdns90321 changed the title flake:Restore default package's buildInputs #3261 flake: Restore default package's buildInputs #3261 Sep 19, 2023
@tpdns90321 tpdns90321 marked this pull request as ready for review September 19, 2023 14:51
@tpdns90321
Copy link
Contributor Author

#3261

@Green-Sky Green-Sky linked an issue Sep 19, 2023 that may be closed by this pull request
@Green-Sky Green-Sky merged commit 80834da into ggerganov:master Sep 20, 2023
5 checks passed
pkrmf pushed a commit to morlockstudios-com/llama.cpp that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build flake's package in nix darwin.
2 participants