Fix bug: missiong pthread link. #874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2024 15:37
slaren
reviewed
Jun 30, 2024
| @@ -426,6 +426,6 @@ set_property(TEST ${TEST_TARGET} PROPERTY ENVIRONMENT "LLVM_PROFILE_FILE=${TEST_ | |||
|
|
|||
| set(TEST_TARGET test-backend-ops) | |||
| add_executable(${TEST_TARGET} ${TEST_TARGET}.cpp) | |||
| target_link_libraries(${TEST_TARGET} PRIVATE ggml) | |||
| target_link_libraries(${TEST_TARGET} PRIVATE ggml pthread) | |||
There was a problem hiding this comment.
This will not work on every OS, eg. it fails on windows. It's not clear why this is needed in your system - test-backend-ops does not use pthread, it uses the C++ standard library. If it is really necessary, this may need to be changed to use the Threads package instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test steps
/usr/bin/ld: CMakeFiles/test-backend-ops.dir/test-backend-ops.cpp.o: undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status