Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sycl : add build instructions #870

Merged
merged 1 commit into from
Jun 30, 2024
Merged

sycl : add build instructions #870

merged 1 commit into from
Jun 30, 2024

Conversation

Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Jun 23, 2024

Tested with oneAPI 2024.2, building is okay on windows.

Compiler Version

icx --version                 
Intel(R) oneAPI DPC++/C++ Compiler for applications running on Intel(R) 64, Version 2024.2.0 Build 20240602
Copyright (C) 1985-2024 Intel Corporation. All rights reserved.

Intel(R) oneAPI DPC++/C++ Compiler 2024.2.0 (2024.2.0.20240602)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files (x86)\Intel\oneAPI\compiler\2024.2\bin\compiler
Configuration file: C:\Program Files (x86)\Intel\oneAPI\compiler\2024.2\bin\compiler\..\icx.cfg

Devices

# I've installed multiple oneAPI variants -- some devices were duplicated...
sycl-ls
[opencl:cpu][opencl:0] Intel(R) OpenCL, 13th Gen Intel(R) Core(TM) i9-13900 OpenCL 3.0 (Build 0) [2024.18.6.0.02_160000]
[opencl:gpu][opencl:1] Intel(R) OpenCL Graphics, Intel(R) Arc(TM) A770 Graphics OpenCL 3.0 NEO  [31.0.101.5522]
[opencl:gpu][opencl:2] Intel(R) OpenCL Graphics, Intel(R) Arc(TM) A750 Graphics OpenCL 3.0 NEO  [31.0.101.5522]
[opencl:cpu][opencl:3] Intel(R) OpenCL, 13th Gen Intel(R) Core(TM) i9-13900 OpenCL 3.0 (Build 0) [2023.16.12.0.12_195853.xmain-hotfix]
[opencl:fpga][opencl:4] Intel(R) FPGA Emulation Platform for OpenCL(TM), Intel(R) FPGA Emulation Device OpenCL 1.2  [2023.16.12.0.12_195853.xmain-hotfix]
[opencl:cpu][opencl:5] Intel(R) OpenCL, 13th Gen Intel(R) Core(TM) i9-13900 OpenCL 3.0 (Build 0) [2024.17.3.0.08_160000]
[opencl:fpga][opencl:6] Intel(R) FPGA Emulation Platform for OpenCL(TM), Intel(R) FPGA Emulation Device OpenCL 1.2  [2024.17.3.0.08_160000]
[level_zero:gpu][level_zero:0] Intel(R) Level-Zero, Intel(R) Arc(TM) A770 Graphics 1.3 [1.3.29283]
[level_zero:gpu][level_zero:1] Intel(R) Level-Zero, Intel(R) Arc(TM) A750 Graphics 1.3 [1.3.29283]

Running test-backend-ops

Using i9-13900 CPU as a SYCL device

set ONEAPI_DEVICE_SELECTOR=opencl:0
.\bin\test-backend-ops.exe

sycl-cpu-test.txt

134 MUL_MAT failures and 1 assertion in ROPE (blocking remaining tests).

Using Intel Arc A770 GPU as a SYCL device

set ONEAPI_DEVICE_SELECTOR=level_zero:0
.\bin\test-backend-ops.exe

sycl-gpu-test.txt

223 failures (4 NORM, 4 RMS_NORM, 164 MUL_MAT, 51 SOFT_MAX) and 1 assertion in ROPE (blocking remaining tests).

@ggerganov
Copy link
Owner

After #865 there should be SYCL build support - please give it a try as it is not tested yet and suggest improvements / build instructions

@Nuullll Nuullll changed the title cmake: enable SYCL build cmake: fix SYCL windows build Jun 28, 2024
@Nuullll
Copy link
Contributor Author

Nuullll commented Jun 28, 2024

After #865 there should be SYCL build support - please give it a try as it is not tested yet and suggest improvements / build instructions

Thanks, didn't notice that. It's almost working on windows except the minor change I made.

@slaren
Copy link
Collaborator

slaren commented Jun 28, 2024

Can you submit this change as a PR to the llama.cpp repository so that other SYCL developers can take a look? The windows SYCL CI in llama.cpp seems to be working correctly without these changes.

@Nuullll
Copy link
Contributor Author

Nuullll commented Jun 28, 2024

Can you submit this change as a PR to the llama.cpp repository so that other SYCL developers can take a look? The windows SYCL CI in llama.cpp seems to be working correctly without these changes.

Thanks for the hint! Using MSVC as C compiler resolves the issue, updated the build instructions.

@Nuullll Nuullll changed the title cmake: fix SYCL windows build sycl : add build instructions Jun 28, 2024
@slaren slaren merged commit 052f2e9 into ggerganov:master Jun 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants