Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] remove global variables (#7710) #858

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Jun 16, 2024

  • separate DPCT helpers outside

  • replace global variables with context

  • remove useless extra

  • update mul_mat condition

  • remove duplicate buft initialization

  • remove duplicate extra and global work group size

  • remove useless backend check

  • remove duplicated extras

  • use macro for group_size and remove cuda-related

@Nuullll Nuullll marked this pull request as draft June 16, 2024 04:00
@Nuullll Nuullll marked this pull request as ready for review June 16, 2024 04:05
@Nuullll
Copy link
Contributor Author

Nuullll commented Jun 16, 2024

The sync script didn't catch ggml-sycl folder. This is a manual sync of ggerganov/llama.cpp#7710

* separate DPCT helpers outside

* replace global variables with context

* remove useless extra

* update mul_mat condition

* remove duplicate buft initialization

* remove duplicate extra and global work group size

* remove useless backend check

* remove duplicated extras

* use macro for group_size and remove cuda-related
@ggerganov
Copy link
Owner

Oh thanks for noticing - let me see if I can fix the sync scripts

@ggerganov ggerganov merged commit 66bacfa into ggerganov:master Jun 16, 2024
@Nuullll Nuullll deleted the sync-sycl branch June 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants