gguf.md: add sharding to naming convention #826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #822 (review) suggestion, adding support for sharding in naming convention.
Was a bit worried about if
-of-
is going to be annoying to parse, but I think it's not too much to ask programmers to check ifXXXXX-of-XXXXX
exist first and delete that before processing the rest from right to left by splitting by-
. The requirement for 5 digits and-of-
is pretty distinctive anyway.@ggerganov this is a PR to add this idea on behalf of @mishig25 and based on checking hf it appears to be a common enough convention already e.g. vicuna.gguf