-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix showing unknown token at gpt_tokenize #801
Open
katsu560
wants to merge
10
commits into
ggerganov:master
Choose a base branch
from
katsu560:fixunknowntoken
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
da02d76
fix unknown token at gpt_tokenize
5ad2866
Merge branch 'ggerganov:master' into fixunknowntoken
katsu560 93f1733
delete same debug code
816578c
commit again
3a8a694
delete same debug code
24f8912
delete some debug code
14169ea
Merge branch 'fixunknowntoken' of https://github.com/katsu560/ggml in…
d6dd3b4
Merge branch 'ggerganov:master' into fixunknowntoken
katsu560 c2ccc65
Merge branch 'ggerganov:master' into fixunknowntoken
katsu560 f33c3e8
Merge branch 'ggerganov:master' into fixunknowntoken
katsu560 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -325,22 +325,38 @@ std::vector<gpt_vocab::id> gpt_tokenize(const gpt_vocab & vocab, const std::stri | |||||||
|
||||||||
// find the longest token that forms each word in words: | ||||||||
std::vector<gpt_vocab::id> tokens; | ||||||||
// unknown token | ||||||||
std::vector<char> unknown; | ||||||||
unknown.clear(); | ||||||||
for (const auto & word : words) { | ||||||||
for (int i = 0; i < (int) word.size(); ){ | ||||||||
for (int j = word.size() - 1; j >= i; j--){ | ||||||||
auto cand = word.substr(i, j-i+1); | ||||||||
auto it = vocab.token_to_id.find(cand); | ||||||||
if (it != vocab.token_to_id.end()){ // word.substr(i, j-i+1) in vocab | ||||||||
if (!unknown.empty()){ | ||||||||
unknown.push_back(0); // terminator | ||||||||
std::string unkstr(unknown.begin(), unknown.end()); | ||||||||
fprintf(stderr, "%s: unknown token '%s'\n", __func__, unkstr.data()); | ||||||||
Comment on lines
+339
to
+340
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
unknown.clear(); | ||||||||
} | ||||||||
tokens.push_back(it->second); | ||||||||
i = j + 1; | ||||||||
break; | ||||||||
} | ||||||||
else if (j == i){ // word.substr(i, 1) has no matching | ||||||||
fprintf(stderr, "%s: unknown token '%s'\n", __func__, word.substr(i, 1).data()); | ||||||||
auto unk = word.substr(i, 1).data(); | ||||||||
unknown.push_back(*unk); | ||||||||
Comment on lines
+348
to
+349
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't this just:
Suggested change
|
||||||||
i++; | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
if (!unknown.empty()){ | ||||||||
unknown.push_back(0); // terminator | ||||||||
std::string unkstr(unknown.begin(), unknown.end()); | ||||||||
fprintf(stderr, "%s: unknown token '%s'\n", __func__, unkstr.data()); | ||||||||
Comment on lines
+356
to
+357
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
unknown.clear(); | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
return tokens; | ||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.