Introduce backend GUIDs #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial proposed implementation of backend GUIDs (Discussed in ggerganov#741) Hardcoded CPU backend GUID (for now) Change ggml_backend_is_cpu logic to use GUID
slaren
reviewed
Feb 22, 2024
Remove redundant functions `ggml_backend_i::get_name` and `ggml_backend_guid` which are not desired for future expansion
slaren
reviewed
Feb 22, 2024
Co-authored-by: slaren <[email protected]>
Co-authored-by: slaren <[email protected]>
Co-authored-by: slaren <[email protected]>
OK adding it back, it just seemed like this was redundant in the same ways the other things you wanted removed were. I'm just trying to follow the style of the project and your comments; personally I would have done things very differently so I'm going off your guidance. |
ggerganov
approved these changes
Feb 22, 2024
slaren
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial proposed implementation of backend GUIDs
(Discussed in #741)
Hardcoded CPU backend GUID (for now)
Change ggml_backend_is_cpu logic to use GUID