refactored compute forward to not pass in the src tensors each time #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
reviewed
Feb 12, 2024
src/ggml.c
Outdated
| @@ -2607,7 +2607,7 @@ static struct ggml_tensor * ggml_new_tensor_impl( | |||
| /*.nb =*/ { 0, 0, 0, 0 }, | |||
| /*.op =*/ GGML_OP_NONE, | |||
| /*.op_params =*/ { 0 }, | |||
| /*.flags =*/ 0, | |||
| /*.is_param =*/ false, | |||
There was a problem hiding this comment.
It looks like something went wrong while merging with the latest changes, this and all other uses of flags shouldn't be changed.
There was a problem hiding this comment.
hmm got it, will take a look
There was a problem hiding this comment.
okay I should have fixed all the instances where there were merge issues affecting flags. the code builds now after running make -j4 gpt-2-backend gpt-j so I think it should be in good shape now!
|
looking into why the customop test is failing |
|
all tests are passing locally now! |
slaren
approved these changes
Feb 19, 2024
ggerganov
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intended to address issue #724