metal : add debug capture backend function #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Jan 11, 2024
| @@ -109,6 +109,9 @@ GGML_API ggml_backend_buffer_type_t ggml_backend_metal_buffer_type(void); | |||
| // ref: https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf | |||
| GGML_API bool ggml_backend_metal_supports_family(ggml_backend_t backend, int family); | |||
|
|
|||
| // capture all command buffers committed the next time `ggml_backend_graph_compute` is called | |||
| GGML_API void ggml_backend_metal_capture_next_compute(ggml_backend_t backend); | |||
There was a problem hiding this comment.
@slaren Is it a good idea to extend the backend API with these type of calls or should we try to avoid it. In this case, it could remain a compile-time option (ggerganov/llama.cpp@2a7c94d), but it might be useful to control at runtime in some cases
There was a problem hiding this comment.
Generally I don't see an issue with adding more backend-specific functions, as long as they are not required for normal usage.
ggerganov
force-pushed
the
metal-capture
branch
from
12c2149
to
3296ebd
Compare
ggerganov
force-pushed
the
metal-capture
branch
from
3296ebd
to
40cbc4e
Compare
ggerganov
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggml_backend_metal_capture_next_computewill capture all command buffers the next timeggml_backend_graph_computeis called, simplifying the Metal debugger workflow.