sync : llama.cpp (fused soft max, gpu cpy ops, etc.) #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
|
All 3 repos should be synced now |
slaren
reviewed
Dec 7, 2023
slaren
approved these changes
Dec 7, 2023
ggerganov
commented
Dec 7, 2023
| @@ -8446,7 +8469,7 @@ static void ggml_compute_forward_concat_f32( | |||
| GGML_ASSERT(nb10 == sizeof(float)); | |||
|
|
|||
| for (int i3 = 0; i3 < ne3; i3++) { | |||
| for (int i2 = ith; i2 < ne2; i2++) { | |||
| for (int i2 = ith; i2 < ne2; i2 += nth) { | |||
There was a problem hiding this comment.
@FSSRepo FYI there was a bug in ggml_concat
There was a problem hiding this comment.
This PR already solves it anyway. Right?
There was a problem hiding this comment.
Yes - waiting for CI to pass and will merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.