fix dividing by zero and assertion, and add test-blas0 in make test on x86_64 #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After gq merged to master, make test failed by exception by zero dividing and assertion.
It caused by cgraph->n_threads is zero in ggml.c ggml_graph_compute().
and assertion is GGML_ASSERT(!ggml_is_transposed(a)); in ggml_mul_mat().
And test-blas0 is tested on x86_64 system with using OpenBLAS, but make test is failed.
I fixed tests/CMakeLists.txt to do test-blas0 with command line options '0 0 0'.
test3 is too slow on my old 4-cored PC with running 8 threads setting.
So, n_threads parameter is changed by GGML_NTHREADS or command line option.
It changes test3 time from 50.10sec to 2.35sec.
before:
after:
please confirm this pull request.