Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ADD_REL_POS perf in SAM by doing it inplace #466

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Improve ADD_REL_POS perf in SAM by doing it inplace #466

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58d9081
Improve ADD_REL_POS perf in SAM by doing it inplace
Aug 20, 2023
9d6eaa8
Add non-inplace version for the GGML_OP_ADD_REL_POS
Aug 21, 2023
ca3e0fc
Fix map_unary warnings and refactor LayerNorm2d + remove ggml_cont in it
Aug 21, 2023
d65d74d
Fix Mac printf format warnings
Aug 21, 2023
6e13e28
sam : add ggml_graph_print() comment
ggerganov Aug 21, 2023
d4b3b46
ggml : add broadcast support for BLAS ggml_mul_mat() (#460)
ggerganov Aug 21, 2023
415dbf1
Remove not needed build_forward_expand from add-rel-pos unit test
Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove not needed build_forward_expand from add-rel-pos unit test
  • Loading branch information
YavorGIvanov committed Aug 21, 2023
commit 415dbf173804cc06cc5da4f19233490d2591fdbe
4 changes: 0 additions & 4 deletions tests/test-rel-pos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,10 @@ int main(int argc, const char** argv) {

struct ggml_tensor * out = ggml_add_rel_pos(ctx, in, rw_f32, rh_f32);
struct ggml_cgraph gf = ggml_build_forward(out);
ggml_build_forward_expand(&gf, rw_f32);
ggml_build_forward_expand(&gf, rh_f32);
ggml_graph_compute_with_ctx(ctx, &gf, 1);

out_inplace = ggml_add_rel_pos_inplace(ctx, out_inplace, rw_f32, rh_f32);
struct ggml_cgraph gf_2 = ggml_build_forward(out_inplace);
ggml_build_forward_expand(&gf_2, rw_f32);
ggml_build_forward_expand(&gf_2, rh_f32);
ggml_graph_compute_with_ctx(ctx, &gf_2, 1);

check_tensor(out, (float*)expected_out, 9, 4, 1);
Expand Down
Loading