Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples tensor name access #443

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Fix examples tensor name access #443

merged 7 commits into from
Aug 16, 2023

Conversation

klosax
Copy link
Contributor

@klosax klosax commented Aug 10, 2023

Ref #436

Fixes access of std::string that do not work in gcc 11.

Green-Sky
Green-Sky approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good pr

sidenote: .data() and .c_str() are defined to return the exact same for std::string

@ggerganov ggerganov merged commit 9ed276f into ggerganov:master Aug 16, 2023
2 checks passed
@klosax klosax deleted the fix-examples branch August 17, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klosax @slaren @Green-Sky @ggerganov