Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback to abort ggml_graph_compute() #328

Merged
merged 13 commits into from
Jul 11, 2023
Merged

callback to abort ggml_graph_compute() #328

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
10fb185
mechanism to abort ggml_graph_compute
CCLDArjun Jul 2, 2023
8bff0bd
use pthread_cancel
CCLDArjun Jul 2, 2023
293d605
forgot to commit ggml.h
CCLDArjun Jul 2, 2023
21bdeea
static always_false()
CCLDArjun Jul 3, 2023
f132e16
accept callback data
CCLDArjun Jul 3, 2023
f9432d7
proper function prototype
CCLDArjun Jul 3, 2023
2506a1d
Merge branch 'master' into abort
CCLDArjun Jul 3, 2023
4218d92
return exit status
CCLDArjun Jul 3, 2023
fcd5b17
remove pthread_cancel and join every thread
CCLDArjun Jul 5, 2023
e6a9fe6
Merge branch 'master' into abort
CCLDArjun Jul 11, 2023
47de3d6
put abort_callback onto cplan
CCLDArjun Jul 11, 2023
118809b
cplan abort_callback in ggml.c
CCLDArjun Jul 11, 2023
26b90d0
make sure all threads abort
CCLDArjun Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make sure all threads abort
  • Loading branch information
@CCLDArjun
CCLDArjun committed Jul 11, 2023
commit 26b90d06eae80ef295be14071be714ac8e39ee2f
1 change: 1 addition & 0 deletions src/ggml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15982,6 +15982,7 @@ static thread_ret_t ggml_graph_compute_thread(void * data) {

while (true) {
if (cplan->abort_callback && cplan->abort_callback(cplan->abort_callback_data)) {
state->shared->node_n += 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue while testing that sometimes all but one thread aborts and that one thread is spinning, waiting for shared->node_n to be updated. So, I decided to modify node_n

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Would be nice to have some test program for this functionality added

return GGML_EXIT_ABORTED;
}
if (atomic_fetch_sub(&state->shared->n_active, 1) == 1) {
Expand Down