build : fix compilation errors and warnigns when building with MSVC #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
suggested changes
Jun 21, 2023
Green-Sky
approved these changes
Jun 21, 2023
ggerganov
approved these changes
Jun 24, 2023
Comment on lines
+256
to
+257
| m0[0] = 0-1ULL; | ||
| m1[0] = 0-1ULL; |
There was a problem hiding this comment.
"unary minus applied to unsigned value, result is still unsigned"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of this PR: ggerganov/llama.cpp#1889
This is a cosmetic change. No functionality is changed. Warnings and compilation errors are fixed (and some warnings ignored) leading to a successful build with MSVC on Windows. "possible loss of data" warnings were mostly ignored.
Note that two tests (
test1andtest2) fail on Windows after this, but the failures are unrelated and will be addressed in separate issues