Improve ADD_REL_POS perf in SAM by doing it inplace #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YavorGIvanov
commented
Aug 20, 2023
•
YavorGIvanov
commented
- Add unit test for the ADD_REL_POS operation
- I am not sure if this is valid implementation as we reuse the src0 memory in order to avoid copying it. Alternatively we can do CPY in the model implementation or add_rel_pos with just the rel_w and rel_h tensors and then ggml_add between the result and KQ_scaled
- When running SAM with the "Example output" command, image, point and 16 threads, this reduces the cumulative time of the ADD_REL_POS operation from 1000-1100 ms to 180-200ms (this is on AMD Ryzen Threadripper 2990WX 32-Core Processor)
- There is further room for optimization in the access patterns used in the implementation of the operation
- Resolve ggml : add broadcast support for BLAS ggml_mul_mat() #460
added 3 commits
August 20, 2023 18:34
- Add unit tests for the ADD_REL_POS operation - I am not sure if this is valid implementation as we reuse the src0 memory in order to avoid copying it - When running SAM with the "Example output" command, image, point and 16 threads, this reduces the cumulative time of the ADD_REL_POS operation from 1000-1100 ms to 180-200ms - There is further room for optimization in the access patterns used in the implementation of the opration
|
Added non-inplace version also for the ADD_REL_POS operation and fix deprecated operation warnings (for using map_unary in SAM). Additionally refactoerd LayerNorm2D in separate function and removed 2 ggml_cont from it. I will remove more ggml_conts and ggml_repeats in a separate PR. |
ggerganov
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.