Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Considering ggml 2D tensors are row major, the comment in ggml.h at line 136 and 138 looks incorrect #348

Closed
sankalpdayal opened this issue Jul 6, 2023 · 1 comment
Closed

Considering ggml 2D tensors are row major, the comment in ggml.h at line 136 and 138 looks incorrect #348

sankalpdayal opened this issue Jul 6, 2023 · 1 comment

Comments

@sankalpdayal
Copy link

since nb[0] is stride per element and nb[1] is stride for entire row, an element at index for example row 1 and col 2 will be 1nb[1] + 2nb[0]. However the comment nb[0] and nb[1] are swapped. Just wanted to check if I am understanding it correctly.
@ggerganov
Copy link
Owner

Changed the element indices to correspond to the Python convention - hopefully this is less confusing

CCLDArjun pushed a commit to CCLDArjun/ggml that referenced this issue Dec 18, 2023
@anzz1 @ggerganov
cmdline option for custom amount of model parts (--n_parts N) (ggerga…
975d2ce 
…nov#348)

* cmdline option for custom amount of model parts (--n_parts N)

* Update main.cpp

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggerganov @sankalpdayal