Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support instructor-xl (for text embeddings) #109

Open
sroussey opened this issue Apr 26, 2023 · 3 comments
Open

[Feature Request] Support instructor-xl (for text embeddings) #109

sroussey opened this issue Apr 26, 2023 · 3 comments

Comments

@sroussey
Copy link

It ranks at the top in the hugging-face leaderboard:

https://huggingface.co/spaces/mteb/leaderboard

Here is more info:

https://huggingface.co/hkunlp/instructor-xl

It is a little different... you add an instruction context separately from the thing you want to create embeddings. Quite versatile; obviates the need for many specialized models.

@skeskinen
Copy link
Contributor

It's not instructor-xl, but I've done ggml implementation of BERT for sentence embeddings here: https://github.com/skeskinen/bert.cpp

@ggerganov
Copy link
Owner

@skeskinen

Really well done! Feel free to add a link to your project in ggml’s README
Adding batching support to ggml is getting higher on the TODO list. Now with bert.cpp we’ll have something to easily test with!

@skeskinen
Copy link
Contributor

Thanks! Adding support for batching sounds exiting 👍
It'll be nice to see what kind of speedup it will give and if bert.cpp will be faster than pytorch(cpu) in batched head to head.

CCLDArjun pushed a commit to CCLDArjun/ggml that referenced this issue Dec 18, 2023
…ganov#109)

* Refactor get_n_parts function to simplify code and improve readability

* Use f-strings instead of concatenation

* Refactoring: more concise and readable

* modularize

---------

Co-authored-by: Georgi Gerganov <[email protected]>
CCLDArjun pushed a commit to CCLDArjun/ggml that referenced this issue Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants