Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIME type to get_image_metadata #2409

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

clarfonthey
Copy link
Contributor

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you doing the PR on the next branch?
  • Have you created/updated the relevant documentation page(s)?

This is required for OpenGraph under the og:image:type field, and probably other cases.

Also updated the documentation to clarify that get_image_metadata doesn't return the extension of the image, but the most common one for its format, so for example image.jpeg will show its format as jpg.

@clarfonthey clarfonthey force-pushed the image-meta-mime branch 2 times, most recently from 5ad5806 to b5d4bee Compare January 27, 2024 23:57
@Keats Keats merged commit 472b1f5 into getzola:next Feb 29, 2024
5 checks passed
@Keats
Copy link
Collaborator

Keats commented Feb 29, 2024

Thanks!

@clarfonthey clarfonthey deleted the image-meta-mime branch February 29, 2024 21:43
veluca93 pushed a commit to veluca93/zola that referenced this pull request May 14, 2024
Keats pushed a commit that referenced this pull request Jun 20, 2024
berdandy pushed a commit to berdandy/azola that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants