Speedup "zola check" command by reusing the Client #2171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
The code changes that
zola check
reuses the reqwest Client instead of creating it for every single request.The benefit of this is a major speedup since it is able to reuse the connections. This is especially helpful for big pages like the one I am working on (17733 external links). The current stable way takes multiple hours, while this PR makes it go down to way less (as of writing it is still running but the progress bar I added in my local code predicts it to take 30-40 minutes instead of 14h+).
next
branch?If the change is a new feature or adding to/changing an existing one: