Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undocumented breaking change in 0.11.0 #1047

Closed
bdjnk opened this issue Jun 2, 2020 · 3 comments
Closed

undocumented breaking change in 0.11.0 #1047

bdjnk opened this issue Jun 2, 2020 · 3 comments

Comments

@bdjnk
Copy link
Contributor

bdjnk commented Jun 2, 2020

Documentation issue

Summary

PR #1026 (commit 32ca1a1) is a breaking change in 0.11.0 yet it isn't mentioned in the changelog at all nor otherwise documented.

Proposed solution

Document this change properly. Ensure any future change which alters the generated html is listed as breaking and documented appropriately.
Keats added a commit that referenced this issue Jun 3, 2020
@Keats
Mention 0.11 breaking change
a9a3a2e 
Closes #1047
@Keats
Copy link
Collaborator

Keats commented Jun 3, 2020

Missed that one sorry :(

@bdjnk
Copy link
Contributor Author

bdjnk commented Jun 3, 2020

Sorry to continue this, but you committed against next instead of master and forgot an ending backtick. I created a PR against master if that's helpful. #1049

@Keats
Copy link
Collaborator

Keats commented Jun 3, 2020

Sorry :(

@Keats Keats closed this as completed Jun 3, 2020
XAMPPRocky pushed a commit to XAMPPRocky/zola that referenced this issue Jul 29, 2020
@Keats @XAMPPRocky
Mention 0.11 breaking change
fc544c0 
Closes getzola#1047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdjnk @Keats