feat: Support more complicated path_regexp (issues/826) #829
Conversation
v3.6.1 - develop -> master
config/config.go
Outdated
| rule = &r | ||
| break | ||
| } | ||
| if regexp.MustCompile(r.PathRegex).MatchString(filePath) { |
There was a problem hiding this comment.
The if r.PathRegex != "" { is missing.
Also, I'm not sure whether using MustCompile here is a good idea in terms of error handling. It will panic if r.PathRegex does not compile. The old code was simply ignoring errors, which might not be the be solution, but panicing instead is not a good idea IMO.
There was a problem hiding this comment.
The
if r.PathRegex != "" {is missing.Also, I'm not sure whether using
MustCompilehere is a good idea in terms of error handling. It will panic ifr.PathRegexdoes not compile. The old code was simply ignoring errors, which might not be the be solution, but panicing instead is not a good idea IMO.
@felixfontein , the if r.PathRegex != "" { is useless because we check if the string is empty before, and if it's the case, then it breaks. So the string is not empty at this point.
I update the code so I return an error instead of panicing.
Ref: #826
This should works. But @sfrevel, if you have better examples so I can complete the tests? (but I guess it could be okay like that already...).